From: Alessandro Bono <alessandro.bono369@gmail.com>
Date: Thu, 5 Sep 2024 12:41:30 +0000 (+0200)
Subject: environment: Make more explicit what are the default values
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~204^2^2~16
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=91ae7de3adf131f6574e93b7bdf7a1b3b89be86f;p=gnome-shell.git

environment: Make more explicit what are the default values

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2986>
---

diff --git a/js/ui/environment.js b/js/ui/environment.js
index 24e52d739..784a45271 100644
--- a/js/ui/environment.js
+++ b/js/ui/environment.js
@@ -90,6 +90,12 @@ function _getPropertyTarget(actor, propName) {
 }
 
 function _easeActor(actor, params) {
+    params = {
+        repeatCount: 0,
+        autoReverse: false,
+        ...params,
+    };
+
     actor.save_easing_state();
 
     if (params.duration !== undefined)
@@ -100,14 +106,10 @@ function _easeActor(actor, params) {
         actor.set_easing_delay(params.delay);
     delete params.delay;
 
-    let repeatCount = 0;
-    if (params.repeatCount !== undefined)
-        repeatCount = params.repeatCount;
+    const repeatCount = params.repeatCount;
     delete params.repeatCount;
 
-    let autoReverse = false;
-    if (params.autoReverse !== undefined)
-        autoReverse = params.autoReverse;
+    const autoReverse = params.autoReverse;
     delete params.autoReverse;
 
     // repeatCount doesn't include the initial iteration
@@ -157,6 +159,12 @@ function _easeActor(actor, params) {
 }
 
 function _easeActorProperty(actor, propName, target, params) {
+    params = {
+        repeatCount: 0,
+        autoReverse: false,
+        ...params,
+    };
+
     // Avoid pointless difference with ease()
     if (params.mode)
         params.progress_mode = params.mode;
@@ -166,14 +174,10 @@ function _easeActorProperty(actor, propName, target, params) {
         params.duration = adjustAnimationTime(params.duration);
     let duration = Math.floor(params.duration || 0);
 
-    let repeatCount = 0;
-    if (params.repeatCount !== undefined)
-        repeatCount = params.repeatCount;
+    const repeatCount = params.repeatCount;
     delete params.repeatCount;
 
-    let autoReverse = false;
-    if (params.autoReverse !== undefined)
-        autoReverse = params.autoReverse;
+    const autoReverse = params.autoReverse;
     delete params.autoReverse;
 
     // repeatCount doesn't include the initial iteration